pgsql: Fix local-variable shadowing in pg_trgm's printSourceNFA(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix local-variable shadowing in pg_trgm's printSourceNFA().
Date
Msg-id E1vx98V-0022r9-0W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix local-variable shadowing in pg_trgm's printSourceNFA().

We hadn't noticed this violation of -Wshadow=compatible-local
because this function isn't compiled without -DTRGM_REGEXP_DEBUG.

As long as we have to clean it up, let's do so by converting all
this function's loops to use C99 loop-local control variables.

Reported-by: Sergei Kornilov <sk@zsrv.org>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/3009911772478436@08341ecb-668d-43a9-af4d-b45f00c72521

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cdaa67565867ba443afb66b9e82023d65487dc7c

Modified Files
--------------
contrib/pg_trgm/trgm_regexp.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Add commit 7b24959434 to .git-blame-ignore-revs.
Next
From: Jeff Davis
Date:
Subject: pgsql: style: define parameterless functions as foo(void).