pgsql: basic_archive: Allow archive directory to be missing at startup. - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: basic_archive: Allow archive directory to be missing at startup.
Date
Msg-id E1vx8je-0022f8-2V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
basic_archive: Allow archive directory to be missing at startup.

Presently, the GUC check hook for basic_archive.archive_directory
checks that the specified directory exists.  Consequently, if the
directory does not exist at server startup, archiving will be stuck
indefinitely, even if it appears later.  To fix, remove this check
from the hook so that archiving will resume automatically once the
directory is present.  basic_archive must already be prepared to
deal with the directory disappearing at any time, so no additional
special handling is required.

Reported-by: Олег Самойлов <splarv@ya.ru>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Sergei Kornilov <sk@zsrv.org>
Discussion: https://postgr.es/m/73271769675212%40mail.yandex.ru
Backpatch-through: 15

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f510577de4f5a0b33453941a08cdb2302dc55f02

Modified Files
--------------
contrib/basic_archive/basic_archive.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix OldestMemberMXactId and OldestVisibleMXactId array usage
Next
From: Nathan Bossart
Date:
Subject: pgsql: Add commit 7b24959434 to .git-blame-ignore-revs.