pgsql: Fix more multibyte issues in ltree. - Mailing list pgsql-committers

From Jeff Davis
Subject pgsql: Fix more multibyte issues in ltree.
Date
Msg-id E1vvi0Z-001Ik8-1Q@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix more multibyte issues in ltree.
List pgsql-committers
Fix more multibyte issues in ltree.

Commit 84d5efa7e3 missed some multibyte issues caused by short-circuit
logic in the callers. The callers assumed that if the predicate string
is longer than the label string, then it couldn't possibly be a match,
but it can be when using case-insensitive matching (LVAR_INCASE) if
casefolding changes the byte length.

Fix by refactoring to get rid of the short-circuit logic as well as
the function pointer, and consolidate the logic in a replacement
function ltree_label_match().

Discussion: https://postgr.es/m/02c6ef6cf56a5013ede61ad03c7a26affd27d449.camel@j-davis.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b3c2a3d386fa91421d81f51ff759fad4f31b6479

Modified Files
--------------
contrib/ltree/lquery_op.c    | 111 +++++++++++++++++++++----------------------
contrib/ltree/ltree.h        |  10 ++--
contrib/ltree/ltxtquery_op.c |  11 ++---
3 files changed, 63 insertions(+), 69 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Fix more multibyte issues in ltree.
Next
From: Jeff Davis
Date:
Subject: pgsql: Fix more multibyte issues in ltree.