pgsql: Stabilize output of new isolation test insert-conflict-do-update - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Stabilize output of new isolation test insert-conflict-do-update
Date
Msg-id E1vvHB6-0017DR-2n@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Stabilize output of new isolation test insert-conflict-do-update-4.

The test added by commit 4b760a181 assumed that a table's physical
row order would be predictable after an UPDATE.  But a non-heap table
AM might produce some other order.  Even with heap AM, the assumption
seems risky; compare a3fd53bab for instance.  Adding an ORDER BY is
cheap insurance and doesn't break any goal of the test.

Author: Pavel Borisov <pashkin.elfe@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0a2600e4cd525382212581267877ca6e5bbdf335

Modified Files
--------------
src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++----
src/test/isolation/specs/insert-conflict-do-update-4.spec   | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Richard Guo
Date:
Subject: pgsql: Fix unsafe RTE_GROUP removal in simplify_EXISTS_query
Next
From: Tom Lane
Date:
Subject: pgsql: Fix some cases of indirectly casting away const.