pgsql: Enable -Wimplicit-fallthrough option for clang - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Enable -Wimplicit-fallthrough option for clang
Date
Msg-id E1vuPwA-000lzX-03@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Enable -Wimplicit-fallthrough option for clang

On clang, -Wimplicit-fallthrough requires annotations with attributes,
but on gcc, -Wimplicit-fallthrough is the same as
-Wimplicit-fallthrough=3, which allows annotations with comments.  In
order to enforce consistent annotations with attributes on both
compilers, we test first for -Wimplicit-fallthrough=5, which will
succeed on gcc, and if that is not found we test for
-Wimplicit-fallthrough.

Reviewed-by: Jelte Fennema-Nio <postgres@jeltef.nl>
Discussion: https://www.postgresql.org/message-id/flat/76a8efcd-925a-4eaf-bdd1-d972cd1a32ff%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0284e07599a53d27d744042c10aec3e2e674d5b5

Modified Files
--------------
configure    | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
configure.ac |  14 ++++++++
meson.build  |  19 ++++++++++-
3 files changed, 135 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix additional fallthrough warnings from clang
Next
From: Peter Eisentraut
Date:
Subject: pgsql: meson: Refactor libpq targets variables