pgsql: hstore: Fix NULL pointer dereference with receive function - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: hstore: Fix NULL pointer dereference with receive function
Date
Msg-id E1vs8E3-001B84-3D@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
hstore: Fix NULL pointer dereference with receive function

The receive function of hstore was not able to handle correctly
duplicate key values when a new duplicate links to a NULL value, where a
pfree() could be attempted on a NULL pointer, crashing due to a pointer
dereference.

This problem would happen for a COPY BINARY, when stacking values like
that:
aa => 5
aa => null

The second key/value pair is discarded and pfree() calls are attempted
on its key and its value, leading to a pointer dereference for the value
part as the value is NULL.  The first key/value pair takes priority when
a duplicate is found.

Per offline report.

Reported-by: "Anemone" <vergissmeinnichtzh@gmail.com>
Reported-by: "A1ex" <alex000young@gmail.com>
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/31d0b917d162b4d5401e1f0ebd27f987d44cbabf

Modified Files
--------------
contrib/hstore/hstore_io.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: pg_upgrade: Use COPY for LO metadata for upgrades from < v12.
Next
From: Noah Misch
Date:
Subject: pgsql: Suppress new "may be used uninitialized" warning.