pgsql: Don't reset 'latest_page_number' when replaying multixid truncat - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Don't reset 'latest_page_number' when replaying multixid truncat
Date
Msg-id E1vs12i-0017ar-0h@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't reset 'latest_page_number' when replaying multixid truncation

'latest_page_number' is set to the correct value, according to
nextOffset, early at system startup. Contrary to the comment, it hence
should be set up correctly by the time we get to WAL replay.

This fixes a failure to replay WAL generated on older minor versions,
before commit 789d65364c (18.2, 17.8, 16.12, 15.16, 14.21). The
failure occurs after a truncation record has been replayed and looks
like this:

    FATAL:  could not access status of transaction 858112
    DETAIL:  Could not read from file "pg_multixact/offsets/000D" at offset 24576: read too few bytes.
    CONTEXT:  WAL redo at 3/2A3AB408 for MultiXact/CREATE_ID: 858111 offset 6695072 nmembers 5: 1048228 (sh) 1048271
(keysh)1048316 (sh) 1048344 (keysh) 1048370 (sh) 

Reported-by: Sebastian Webber <sebastian@swebber.me>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/20260214090150.GC2297@p46.dedyn.io;lightning.p46.dedyn.io
Backpatch-through: 14-18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/817f74600d0d015309596762c9e4a07e0ac8fdbf

Modified Files
--------------
src/backend/access/transam/multixact.c | 10 ----------
src/include/access/slru.h              |  4 +++-
2 files changed, 3 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Add note to ssl_group config on X25519 and FIPS
Next
From: Tom Lane
Date:
Subject: pgsql: Ensure that all three build methods install the same set of file