pgsql: Further stabilize a postgres_fdw test case. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Further stabilize a postgres_fdw test case.
Date
Msg-id E1vqCgc-000D7P-1p@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Further stabilize a postgres_fdw test case.

The buildfarm occasionally shows a variant row order in the output
of this UPDATE ... RETURNING, implying that the preceding INSERT
dropped one of the rows into some free space within the table rather
than appending them all at the end.  It's not entirely clear why that
happens some times and not other times, but we have established that
it's affected by concurrent activity in other databases of the
cluster.  In any case, the behavior is not wrong; the test is at fault
for presuming that a seqscan will give deterministic row ordering.
Add an ORDER BY atop the update to stop the buildfarm noise.

The buildfarm seems to have shown this only in v18 and master
branches, but just in case the cause is older, back-patch to
all supported branches.

Discussion: https://postgr.es/m/3866274.1770743162@sss.pgh.pa.us
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/946b653b7ab9f5c41f153cac7f05fe94772d8319

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 35 +++++++++++++++++---------
contrib/postgres_fdw/sql/postgres_fdw.sql      | 11 ++++++--
2 files changed, 32 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Cleanup for log_min_messages changes in 38e0190ced71
Next
From: Nathan Bossart
Date:
Subject: pgsql: Add password expiration warnings.