pgsql: Fix CI failure introduced in commit 851f6649cc. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix CI failure introduced in commit 851f6649cc.
Date
Msg-id E1vlImD-003J7t-1J@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix CI failure introduced in commit 851f6649cc.

The test added in commit 851f6649cc uses a backup taken from a node
created by the previous test to perform standby related checks. On
Windows, however, the standby failed to start with the following error:
FATAL:  could not rename file "backup_label" to "backup_label.old": Permission denied

This occurred because some background sessions from the earlier test were
still active. These leftover processes continued accessing the parent
directory of the backup_label file, likely preventing the rename and
causing the failure. Ensuring that these sessions are cleanly terminated
resolves the issue in local testing.

Additionally, the has_restoring => 1 option has been removed, as it was
not required by the new test.

Reported-by: Robert Haas <robertmhaas@gmail.com>
Backpatch-through: 17
Discussion: https://postgr.es/m/CA+TgmobdVhO0ckZfsBZ0wqDO4qHVCwZZx8sf=EinafvUam-dsQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3a98f989e8e596efb0db942ead90f64800136fac

Modified Files
--------------
src/test/recovery/t/046_checkpoint_logical_slot.pl | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add support for "mcv" in pg_restore_extended_stats()
Next
From: Michael Paquier
Date:
Subject: pgsql: Add test for pg_restore_extended_stats() with multiranges