pgsql: Remove unnecessary abort() from WalSndShutdown(). - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Remove unnecessary abort() from WalSndShutdown().
Date
Msg-id E1vkZFz-002sv1-0o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove unnecessary abort() from WalSndShutdown().

WalSndShutdown() previously called abort() after proc_exit(0) to
silence compiler warnings. This is no longer needed, because both
WalSndShutdown() and proc_exit() are declared pg_noreturn,
allowing the compiler to recognize that the function does not return.
Also there are already other functions, such as CheckpointerMain(),
that call proc_exit() without an abort(), and they do not produce warnings.

Therefore this abort() call in WalSndShutdown() is useless and
this commit removes it.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/CAHGQGwHPX1yoixq+YB5rF4zL90TMmSEa3FpHURtqW3Jc5+=oSA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1ea44d7ddfb6ebacb6fb8ae2f5d6e904b2394f29

Modified Files
--------------
src/backend/replication/walsender.c | 1 -
1 file changed, 1 deletion(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: pgindent fix for 3fccbd94cba
Next
From: Michael Paquier
Date:
Subject: pgsql: Include extended statistics data in pg_dump