pgsql: Lookup the correct ordering for parallel GIN builds - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Lookup the correct ordering for parallel GIN builds
Date
Msg-id E1vkSGI-002owd-0E@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Lookup the correct ordering for parallel GIN builds

When building a tuplesort during parallel GIN builds, the function
incorrectly looked up the default B-Tree operator, not the function
associated with the GIN opclass (through GIN_COMPARE_PROC).

Fixed by using the same logic as initGinState(), and the other place
in parallel GIN builds.

This could cause two types of issues. First, a data type might not have
a B-Tree opclass, in which case the PrepareSortSupportFromOrderingOp()
fails with an ERROR. Second, a data type might have both B-Tree and GIN
opclasses, defining order/equality in different ways. This could lead to
logical corruption in the index.

Backpatch to 18, where parallel GIN builds were introduced.

Discussion: https://postgr.es/m/73a28b94-43d5-4f77-b26e-0d642f6de777@iki.fi
Reported-by: Heikki Linnakangas <hlinnaka@iki.fi>
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/db14dcdec69d560013b326ca3dea45b83a07ccd6

Modified Files
--------------
src/backend/utils/sort/tuplesortvariants.c | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Reduce length of TAP test file name.
Next
From: Tomas Vondra
Date:
Subject: pgsql: Exercise parallel GIN builds in regression tests