pgsql: Fix missing initialization in pg_restore_extended_stats() - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix missing initialization in pg_restore_extended_stats()
Date
Msg-id E1vkGo3-002hfs-2O@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix missing initialization in pg_restore_extended_stats()

The tuple data upserted into pg_statistic_ext_data was missing an
initialization for the nulls flag of stxoid and stxdinherit.  This would
cause an incorrect handling of the stats data restored.

This issue has been spotted by CatalogTupleCheckConstraints(),
translating to a NOT NULL constraint inconsistency, while playing more
with the follow-up portions of the patch set.

Oversight in 0e80f3f88dea (mea culpa).  Surprisingly, the buildfarm did
not complain yet.

Discussion: https://postgr.es/m/CADkLM=c7DY3Jv6ef0n_MGUJ1FyTMUoT697LbkST05nraVGNHYg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/114e84c532d1493bbabcaf8ab79a3f1830e8bf9e

Modified Files
--------------
src/backend/statistics/extended_stats_funcs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add pg_restore_extended_stats()
Next
From: Michael Paquier
Date:
Subject: pgsql: Add test for MAINTAIN permission with pg_restore_extended_stats(