pgsql: Remove PG_MMAP_FLAGS from mem.h - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Remove PG_MMAP_FLAGS from mem.h
Date
Msg-id E1vkBmU-002ehg-3D@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove PG_MMAP_FLAGS from mem.h

Based on name of the macro, it was implied that it could be used for all
mmap() calls on portability grounds.  However, its use is limited to
sysv_shmem.c, for CreateAnonymousSegment().  This commit removes the
declaration, reducing the confusion around it as a portability tweak,
being limited to SysV-style shared memory.

This macro has been introduced in b0fc0df9364d for sysv_shmem.c,
originally.  It has been moved to mem.h in 0ac5e5a7e152 a bit later.

Suggested by: Peter Eisentraut <peter@eisentraut.org>
Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://postgr.es/m/CAExHW5vTWABxuM5fbQcFkGuTLwaxuZDEE2vtx2WuMUWk6JnF4g@mail.gmail.com
Discussion: https://postgr.es/m/12add41a-7625-4639-a394-a5563e349322@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c100340729b66dc46d4f9d68a794957bf2c468d8

Modified Files
--------------
src/backend/port/sysv_shmem.c | 9 +++++----
src/include/portability/mem.h | 2 --
2 files changed, 5 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Always inline SeqNext and SeqRecheck
Next
From: Michael Paquier
Date:
Subject: pgsql: Add test with multirange type for pg_restore_attribute_stats()