pgsql: Rename "fast" and "slow" popcount functions. - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: Rename "fast" and "slow" popcount functions.
Date
Msg-id E1viehj-001rU2-2X@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rename "fast" and "slow" popcount functions.

Since we now have several implementations of the popcount
functions, let's give them more descriptive names.  This commit
replaces "slow" with "portable" and "fast" with "sse42".  While the
POPCNT instruction is technically not part of SSE4.2, this naming
scheme is close enough in practice and is arguably easier to
understand than using "popcnt" instead.

Reviewed-by: John Naylor <johncnaylorls@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/aWf_InS1VrbeXAfP%40nathan

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8c6653516c5ad23628cc50d4cee1e6446e7f758d

Modified Files
--------------
src/include/port/pg_bitutils.h |  8 +++---
src/port/pg_bitutils.c         | 38 ++++++++++++++--------------
src/port/pg_popcount_x86.c     | 56 ++++++++++++++++++++++--------------------
3 files changed, 53 insertions(+), 49 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Force standard_conforming_strings to always be ON.
Next
From: Peter Smith
Date:
Subject: Re: pgsql: tests: Add a test C++ extension module