pgsql: pg_stat_statements: Add more tests for level tracking - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: pg_stat_statements: Add more tests for level tracking
Date
Msg-id E1viUN0-001l8p-2q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_stat_statements: Add more tests for level tracking

This commit adds tests to verify the computation of the nesting level
for two code paths: the planner hook and the ExecutorFinish() hook.  The
nesting level is essential to save a correct "toplevel" status for the
added PGSS entries.

The author has noticed that removing the manipulations of nesting_level
in these two code paths did not cause the tests to complain, meaning
that we never had coverage for the assumptions taken by the code.

Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/CAA5RZ0uK1PSrgf52bWCtDpzaqbWt04o6ZA7zBm6UQyv7vyvf9w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1572ea96e65731eee3227fbc3c119bd9f39e8e50

Modified Files
--------------
.../pg_stat_statements/expected/level_tracking.out | 66 ++++++++++++++++++++++
contrib/pg_stat_statements/sql/level_tracking.sql  | 38 +++++++++++++
2 files changed, 104 insertions(+)


pgsql-committers by date:

Previous
From: "Jelte Fennema-Nio"
Date:
Subject: Re: pgsql: tests: Add a test C++ extension module
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: tests: Add a test C++ extension module