pgsql: Remove redundant pg_unreachable() after elog(ERROR) from ExecWai - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Remove redundant pg_unreachable() after elog(ERROR) from ExecWai
Date
Msg-id E1viCRG-001cP7-0X@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove redundant pg_unreachable() after elog(ERROR) from ExecWaitStmt()

elog(ERROR) never returns.  Compilers don't always understand this.  So,
sometimes, we have to append pg_unreachable() to keep the compiler quiet
about returning from a non-void function without a value.  But
pg_unreachable() is redundant for ExecWaitStmt(), which is void.

Reported-by: Peter Eisentraut <peter@eisentraut.org>
Author: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/8d72a2b3-7423-4a15-a981-e130bf60b1a6%40eisentraut.org
Discussion: https://postgr.es/m/CABPTF7UcuVD0L-X%3DjZFfeygjPaZWWkVRwtWOaJw2tcXbEN2xsA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/30776ca46865f9e04ff6eb5cfdd64eb8bf5c4ff1

Modified Files
--------------
src/backend/commands/wait.c | 3 ---
1 file changed, 3 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix concurrent sequence drops during sequence synchronization.
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Use integer backend type when exec'ing a postmaster child