pgsql: Improve pg_clear_extended_stats() with incorrect relation/stats - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve pg_clear_extended_stats() with incorrect relation/stats
Date
Msg-id E1vgdH6-000kqz-23@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve pg_clear_extended_stats() with incorrect relation/stats combination

Issue fat-fingered in d756fa1019ff, noticed while doing more review of
the main patch set proposed.  I have missed the fact that this can be
triggered by specifying an extended stats object that does not match
with the relation specified and already locked.  Like the cases where
an object defined in input is missing, the code is changed to issue a
WARNING instead of a confusing cache lookup failure.

A regression test is added to cover this case.

Discussion: https://postgr.es/m/CADkLM=dpz3KFnqP-dgJ-zvRvtjsa8UZv8wDAQdqho=qN3kX0Zg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/395b73c045e02bbe5a33c10f57f528a4468a56f4

Modified Files
--------------
src/backend/statistics/extended_stats_funcs.c | 11 +++++++++--
src/test/regress/expected/stats_import.out    | 12 ++++++++++++
src/test/regress/sql/stats_import.sql         |  6 ++++++
3 files changed, 27 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: pgsql: Fix rowmark handling for non-relation RTEs during executor init
Next
From: Andres Freund
Date:
Subject: pgsql: bufmgr: Avoid spurious compiler warning after fcb9c977aa5