pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch
Date
Msg-id E1vgagn-000jfu-31@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_recvlogical: remove unnecessary OutputFsync() return value checks.

Commit 1e2fddfa33d changed OutputFsync() so that it always returns true.
However, pg_recvlogical.c still contained checks of its boolean return
value, which are now redundant.

This commit removes those checks and changes the type of return value of
OutputFsync() to void, simplifying the code.

Suggested-by: Yilin Zhang <jiezhilove@126.com>
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Mircea Cadariu <cadariu.mircea@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwFeTymZQ7RLvMU6WuDGar8bUQCazg=VOfA-9GeBkg-FzA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b98cc4a14e538d0bc139f50606249b99cc9215cd

Modified Files
--------------
src/bin/pg_basebackup/pg_recvlogical.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix stability issue with new TAP test of pg_createsubscriber
Next
From: Amit Langote
Date:
Subject: pgsql: Fix segfault from releasing locks in detached DSM segments