pgsql: Wake up autovacuum launcher from postmaster when a worker exits - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Wake up autovacuum launcher from postmaster when a worker exits
Date
Msg-id E1vgPo1-000dVH-1x@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Wake up autovacuum launcher from postmaster when a worker exits

When an autovacuum worker exits, the launcher needs to be notified
with SIGUSR2, so that it can rebalance and possibly launch a new
worker. The launcher must be notified only after the worker has
finished ProcKill(), so that the worker slot is available for a new
worker. Before this commit, the autovacuum worker was responsible for
that, which required a slightly complicated dance to pass the
launcher's PID from FreeWorkerInfo() to ProcKill() in a global
variable.

Simplify that by moving the responsibility of the signaling to the
postmaster. The postmaster was already doing it when it failed to fork
a worker process, so it seems logical to make it responsible for
notifying the launcher on worker exit too. That's also how the
notification on background worker exit is done.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: li carol <carol.li2025@outlook.com>
Discussion: https://www.postgresql.org/message-id/a5e27d25-c7e7-45d5-9bac-a17c8f462def@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d9c3c943653740d1df44385c3cd658ed67bb4fb2

Modified Files
--------------
src/backend/postmaster/autovacuum.c | 22 ----------------------
src/backend/postmaster/postmaster.c |  8 ++++++++
src/backend/storage/lmgr/proc.c     |  4 ----
src/include/postmaster/autovacuum.h |  3 ---
4 files changed, 8 insertions(+), 29 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Add check for invalid offset at multixid truncation
Next
From: Andres Freund
Date:
Subject: pgsql: aio: io_uring: Fix danger of completion getting reused before be