pgsql: pg_waldump: Relax LSN comparison check in TAP test - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: pg_waldump: Relax LSN comparison check in TAP test
Date
Msg-id E1vfuuD-000NaE-2m@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_waldump: Relax LSN comparison check in TAP test

The test 002_save_fullpage.pl, checking --save-fullpage fails with
wal_consistency_checking enabled, due to the fact that the block saved
in the file has the same LSN as the LSN used in the file name.  The test
required that the block LSN is stritly lower than file LSN.  This commit
relaxes the check a bit, by allowing the LSNs to match.

While on it, the test name is reworded to include some information about
the file and block LSNs, which is useful for debugging.

Author: Andrey Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4fe1ea7777c8161c655364345d0429cf74f21db4

Modified Files
--------------
src/bin/pg_waldump/t/002_save_fullpage.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: lwlock: Invert meaning of LW_FLAG_RELEASE_OK
Next
From: Amit Kapila
Date:
Subject: pgsql: Prevent unintended dropping of active replication origins.