pgsql: Improve "constraint must include all partitioning columns" messa - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve "constraint must include all partitioning columns" messa
Date
Msg-id E1veGlv-005XaC-2n@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve "constraint must include all partitioning columns" message.

This formerly said "unique constraint must ...", which was accurate
enough when it only applied to UNIQUE and PRIMARY KEY constraints.
However, now we use it for exclusion constraints too, and in that
case it's a tad confusing.  Do what we already did in the errdetail
message: print the constraint_type, so that it looks like "UNIQUE
constraint ...", "EXCLUDE constraint ...", etc.

Author: jian he <jian.universality@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACJufxH6VhAf65Vghg4T2q315gY=Rt4BUfMyunkfRj0n2S9n-g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7a1d422e39baac3627f5a67e7e16dcc6110830dc

Modified Files
--------------
src/backend/commands/indexcmds.c       |  5 ++++-
src/test/regress/expected/indexing.out | 26 +++++++++++++-------------
2 files changed, 17 insertions(+), 14 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: pg_dump: Fix gathering of sequence information.
Next
From: Jacob Champion
Date:
Subject: pgsql: doc: Improve description of publish_via_partition_root