pgsql: Improve portability of new worker_spi test - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve portability of new worker_spi test
Date
Msg-id E1vd5Bu-004r2B-03@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve portability of new worker_spi test

The new test 002_worker_terminate relies on the generation of a LOG
entry to check that a worker has been started, but missed the fact that
a node set with log_error_verbosity = verbose would add an error code.
The regexp used for the matching check did not take this case into
account, making the test fail on a timeout.  The regexp is now fixed to
handle the verbose case correctly.

Per buildfarm member prion, that uses log_error_verbosity = verbose.
The error was reproducible by setting this GUC the same way in the test.

Oversight in f1e251be80a0.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0547aeae0fd6f6d03dd7499c84145ad9e3aa51b9

Modified Files
--------------
src/test/modules/worker_spi/t/002_worker_terminate.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Add test coverage for indirection transformation
Next
From: Jeff Davis
Date:
Subject: pgsql: ICU: use UTF8-optimized case conversion API