pgsql: Update comments atop ReplicationSlotCreate. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Update comments atop ReplicationSlotCreate.
Date
Msg-id E1vczLg-004may-05@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Update comments atop ReplicationSlotCreate.

Since commit 1462aad2e4, which introduced the ability to modify the
two_phase property of a slot, the comments above ReplicationSlotCreate
have become outdated. We have now added a cautionary note in the comments
above ReplicationSlotAlter explaining when it is safe to modify the
two_phase property of a slot.

Author: Daniil Davydov <3danissimo@gmail.com>
Author: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Backpatch-through: 18
Discussion: https://postgr.es/m/CAJDiXggZXQZ7bD0QcTizDt6us9aX6ZKK4dWxzgb5x3+TsVHjqQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c970bdc037f4f35f1ff852b4c032f5fb3f6f6622

Modified Files
--------------
src/backend/replication/slot.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix issue with EVENT TRIGGERS and ALTER PUBLICATION
Next
From: Michael Paquier
Date:
Subject: pgsql: Allow bgworkers to be terminated for database-related commands