pgsql: Do not emit WAL for unlogged BRIN indexes - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Do not emit WAL for unlogged BRIN indexes
Date
Msg-id E1vWDot-001QI9-1g@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Do not emit WAL for unlogged BRIN indexes

Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.

The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:

    FATAL:  could not create file "base/5/32819": File exists

Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d77a5f98176ffaf3a537f4683ec87044c21bb98c

Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix intermittent BF failure in 040_standby_failover_slots_sync.
Next
From: Noah Misch
Date:
Subject: pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs.