pgsql: libpq-oauth: Don't translate internal errors - Mailing list pgsql-committers

From Jacob Champion
Subject pgsql: libpq-oauth: Don't translate internal errors
Date
Msg-id E1vVH3b-000yaW-27@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
libpq-oauth: Don't translate internal errors

Some error messages are generated when OAuth multiplexer operations fail
unexpectedly in the client. Álvaro pointed out that these are both
difficult to translate idiomatically (as they use internal terminology
heavily) and of dubious translation value to end users (since they're
going to need to get developer help anyway). The response parsing engine
has a similar issue.

Remove these from the translation files by introducing internal variants
of actx_error() and oauth_parse_set_error().

Suggested-by: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/CAOYmi%2BkQQ8vpRcoSrA5EQ98Wa3G6jFj1yRHs6mh1V7ohkTC7JA%40mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/aac25567fec10b7b2cc382654e5586acebec5431

Modified Files
--------------
src/interfaces/libpq-oauth/oauth-curl.c | 85 +++++++++++++++++----------------
1 file changed, 45 insertions(+), 40 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Allow passing a pointer to GetNamedDSMSegment()'s init callback.
Next
From: Tom Lane
Date:
Subject: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur