pgsql: bufmgr: Add one-entry cache for private refcount - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: bufmgr: Add one-entry cache for private refcount
Date
Msg-id E1vUqe6-000lAT-1V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
bufmgr: Add one-entry cache for private refcount

The private refcount entry for a buffer is often looked up repeatedly for the
same buffer, e.g. to pin and then unpin a buffer. Benchmarking shows that it's
worthwhile to have a one-entry cache for that case. With that cache in place,
it's worth splitting GetPrivateRefCountEntry() into a small inline
portion (for the cache hit case) and an out-of-line helper for the rest.

This is helpful for some workloads today, but becomes more important in an
upcoming patch that will utilize the private refcount infrastructure to also
store whether the buffer is currently locked, as that increases the rate of
lookups substantially.

Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/6rgb2nvhyvnszz4ul3wfzlf5rheb2kkwrglthnna7qhe24onwr@vw27225tkyar

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/30df61990c67f0cf7450e36c1e038d513960f148

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 66 ++++++++++++++++++++++++++++++-------
1 file changed, 55 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Try a few different locale name spellings in nls.sql.
Next
From: Tom Lane
Date:
Subject: pgsql: Looks like we can't test NLS on machines that lack any es_ES loc