pgsql: Implement ALTER TABLE ... SPLIT PARTITION ... command - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Implement ALTER TABLE ... SPLIT PARTITION ... command
Date
Msg-id E1vUkIb-000hms-0F@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Implement ALTER TABLE ... SPLIT PARTITION ... command

This new DDL command splits a single partition into several partitions.  Just
like the ALTER TABLE ... MERGE PARTITIONS ... command, new partitions are
created using the createPartitionTable() function with the parent partition
as the template.

This commit comprises a quite naive implementation which works in a single
process and holds the ACCESS EXCLUSIVE LOCK on the parent table during all
the operations, including the tuple routing.  This is why the new DDL command
can't be recommended for large, partitioned tables under high load.  However,
this implementation comes in handy in certain cases, even as it is.  Also, it
could serve as a foundation for future implementations with less locking and
possibly parallelism.

Discussion: https://postgr.es/m/c73a1746-0cd0-6bdd-6b23-3ae0b7c0c582%40postgrespro.ru
Author: Dmitry Koval <d.koval@postgrespro.ru>
Co-authored-by: Alexander Korotkov <aekorotkov@gmail.com>
Co-authored-by: Tender Wang <tndrwang@gmail.com>
Co-authored-by: Richard Guo <guofenglinux@gmail.com>
Co-authored-by: Dagfinn Ilmari Mannsaker <ilmari@ilmari.org>
Co-authored-by: Fujii Masao <masao.fujii@gmail.com>
Co-authored-by: Jian He <jian.universality@gmail.com>
Reviewed-by: Matthias van de Meent <boekewurm+postgres@gmail.com>
Reviewed-by: Laurenz Albe <laurenz.albe@cybertec.at>
Reviewed-by: Zhihong Yu <zyu@yugabyte.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Robert Haas <rhaas@postgresql.org>
Reviewed-by: Stephane Tachoires <stephane.tachoires@gmail.com>
Reviewed-by: Jian He <jian.universality@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Pavel Borisov <pashkin.elfe@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Daniel Gustafsson <dgustafsson@postgresql.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Noah Misch <noah@leadboat.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4b3d173629f4cd7ab6cd700d1053af5d5c7c9e37

Modified Files
--------------
doc/src/sgml/ddl.sgml                              |   19 +
doc/src/sgml/ref/alter_table.sgml                  |  118 +-
src/backend/commands/tablecmds.c                   |  432 ++++++
src/backend/parser/gram.y                          |   38 +-
src/backend/parser/parse_utilcmd.c                 |  197 ++-
src/backend/partitioning/partbounds.c              |  737 ++++++++-
src/bin/psql/tab-complete.in.c                     |   10 +-
src/include/nodes/parsenodes.h                     |   34 +-
src/include/parser/kwlist.h                        |    1 +
src/include/partitioning/partbounds.h              |    4 +
src/test/isolation/expected/partition-split.out    |  230 +++
src/test/isolation/isolation_schedule              |    1 +
src/test/isolation/specs/partition-split.spec      |   62 +
.../test_ddl_deparse/expected/alter_table.out      |    5 +
.../modules/test_ddl_deparse/sql/alter_table.sql   |    4 +
.../modules/test_ddl_deparse/test_ddl_deparse.c    |    3 +
src/test/regress/expected/partition_split.out      | 1592 ++++++++++++++++++++
src/test/regress/parallel_schedule                 |    2 +-
src/test/regress/sql/partition_split.sql           | 1134 ++++++++++++++
src/tools/pgindent/typedefs.list                   |    2 +
20 files changed, 4585 insertions(+), 40 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: doc: Fix incorrect documentation for test_custom_stats
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Fix usage of palloc() in MERGE/SPLIT PARTITION(s) code