pgsql: Reject opclass options in ON CONFLICT clause - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Reject opclass options in ON CONFLICT clause
Date
Msg-id E1vU3An-000Lhj-24@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Reject opclass options in ON CONFLICT clause

It's as pointless as ASC/DESC and NULLS FIRST/LAST are, so reject all of
them in the same way.  While at it, normalize the others' error messages
to have less translatable strings.  Add tests for these errors.

Noticed while reviewing recent INSERT ON CONFLICT patches.

Author: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/202511271516.oiefpvn3z27m@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/630a93799d538c35c94187e07ef64d566a573a4e

Modified Files
--------------
src/backend/parser/parse_clause.c             | 22 +++++++++++++++-------
src/test/regress/expected/insert_conflict.out | 13 +++++++++++++
src/test/regress/sql/insert_conflict.sql      |  5 +++++
3 files changed, 33 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Replace most StaticAssertStmt() with StaticAssertDecl()
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Clarify comment about temporal foreign keys