pgsql: pg_buffercache: Fix memory allocation formula - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: pg_buffercache: Fix memory allocation formula
Date
Msg-id E1vTYyS-00060t-0e@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_buffercache: Fix memory allocation formula

The code over-allocated the memory required for os_page_status, relying
on uint64 for its element size instead of an int, hence doubling what
was required.  This could mean quite a lot of memory if dealing with a
lot of NUMA pages.

Oversight in ba2a3c2302f1.

Author: David Geier <geidav.pg@gmail.com>
Discussion: https://postgr.es/m/ad0748d4-3080-436e-b0bc-ac8f86a3466a@gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/580b5c2f397fbb2f74c2661cfe53203ed6acead0

Modified Files
--------------
contrib/pg_buffercache/pg_buffercache_pages.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Enhance slot synchronization API to respect promotion signal.
Next
From: Michael Paquier
Date:
Subject: pgsql: Use palloc_object() and palloc_array(), the last change