pgsql: Clarify why _bt_killitems sorts its items array. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Clarify why _bt_killitems sorts its items array.
Date
Msg-id E1vTVpn-0004RC-2C@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Clarify why _bt_killitems sorts its items array.

Make it clear why _bt_killitems sorts the scan's so->killedItems[]
array.  Also add an assertion to the _bt_killitems loop (that iterates
through this array) to verify it accesses tuples in leaf page order.

Follow-up to commit bfb335df58.

Author: Peter Geoghegan <pg@bowt.ie>
Suggested-by: Victor Yegorov <vyegorov@gmail.com>
Discussion: https://postgr.es/m/CAGnEboirgArezZDNeFrR8FOGvKF-Xok333s2iVwWi65gZf8MEA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e16c6f024718cf854f5b76a4a2ed402f1a7911f1

Modified Files
--------------
src/backend/access/nbtree/nbtutils.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix allocation formula in llvmjit_expr.c
Next
From: Amit Kapila
Date:
Subject: pgsql: Enhance slot synchronization API to respect promotion signal.