pgsql: vacuumdb: Move some variables to the vacuumingOptions struct. - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: vacuumdb: Move some variables to the vacuumingOptions struct.
Date
Msg-id E1vT3UE-003g5o-1o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
vacuumdb: Move some variables to the vacuumingOptions struct.

Presently, the "echo" and "quiet" variables are carted around to
various functions, which is a bit tedious.  To simplify things,
this commit moves them into the vacuumingOptions struct and removes
the related function parameters.  While at it, remove some
redundant initialization code in vacuumdb's main() function.

This is preparatory work for a follow-up commit that will add a
--dry-run option to vacuumdb.

Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CADkLM%3DckHkX7Of5SrK7g0LokPUwJ%3Dkk8JU1GXGF5pZ1eBVr0%3DQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cf1450e57799afb683ccbfc482c6f1b5827c81e7

Modified Files
--------------
src/bin/scripts/vacuumdb.c  | 12 +++------
src/bin/scripts/vacuuming.c | 61 ++++++++++++++++++++++-----------------------
src/bin/scripts/vacuuming.h |  4 ++-
3 files changed, 36 insertions(+), 41 deletions(-)


pgsql-committers by date:

Previous
From: Masahiko Sawada
Date:
Subject: pgsql: Add started_by column to pg_stat_progress_analyze view.
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats