pgsql: Use PGAlignedXLogBlock for some code simplification - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Use PGAlignedXLogBlock for some code simplification
Date
Msg-id E1vSbwu-003RV2-1P@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use PGAlignedXLogBlock for some code simplification

The code in BootStrapXLOG() and in pg_test_fsync.c tried to align WAL
buffers in complicated ways.  Also, they still used XLOG_BLCKSZ for
the alignment, even though that should now be PG_IO_ALIGN_SIZE.  This
can now be simplified and made more consistent by using
PGAlignedXLogBlock, either directly in BootStrapXLOG() and using
alignas in pg_test_fsync.c.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/f462a175-b608-44a1-b428-bdf351e914f4%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/804046b39a27973751c920f8f41504697f3f52d5

Modified Files
--------------
src/backend/access/transam/xlog.c     | 12 ++++--------
src/bin/pg_test_fsync/pg_test_fsync.c | 11 ++++-------
2 files changed, 8 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Make ecpg parse.pl more robust with braces