pgsql: Suppress spurious Coverity warning in prune freeze logic - Mailing list pgsql-committers

From Melanie Plageman
Subject pgsql: Suppress spurious Coverity warning in prune freeze logic
Date
Msg-id E1vRJBU-002qc3-1p@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Suppress spurious Coverity warning in prune freeze logic

Adjust the prune_freeze_setup() parameter types of new_relfrozen_xid and
new_relmin_mxid to prevent misleading Coverity analysis.
heap_page_prune_and_freeze() compared these values against NULL when
passing them to prune_freeze_setup(), causing Coverity to assume they
could be NULL and flag a possible null-pointer dereference later, even
though it occurs inside a directly related conditional.

Reported-by: Coverity
Author: Melanie Plageman <melanieplageman@gmail.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/904f9f5ea0e00a88e2429682d01f2ec946bf553a

Modified Files
--------------
src/backend/access/heap/pruneheap.c | 28 ++++++++++++----------------
1 file changed, 12 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Fix key size of PrivateRefCountHash.
Next
From: Michael Paquier
Date:
Subject: pgsql: Show version of nodes in output of TAP tests