pgsql: Simplify hash_xlog_split_allocate_page() - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Simplify hash_xlog_split_allocate_page()
Date
Msg-id E1vQLhh-002Opj-1z@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Simplify hash_xlog_split_allocate_page()

Instead of complicated pointer arithmetic, overlay a uint32 array and
just access the array members.  That's safe thanks to
XLogRecGetBlockData() returning a MAXALIGNed buffer.

Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/aSQy2JawavlVlEB0%40ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/35988b31db7767ba446009611b9928add1d40f98

Modified Files
--------------
src/backend/access/hash/hash_xlog.c | 35 +++++++++++++++++------------------
1 file changed, 17 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Replace pointer comparisons and assignments to literal zero with
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Remove useless casting to same type