pgsql: Fix error reporting for SQL/JSON path type mismatches - Mailing list pgsql-committers

From Amit Langote
Subject pgsql: Fix error reporting for SQL/JSON path type mismatches
Date
Msg-id E1vOSQc-001auY-2O@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix error reporting for SQL/JSON path type mismatches

transformJsonFuncExpr() used exprType()/exprLocation() on the
possibly coerced path expression, which could be NULL when
coercion to jsonpath failed, leading to "cache lookup failed
for type 0" errors.

Preserve the original expression node so that type and location
in the "must be of type jsonpath" error are reported correctly.
Add regression tests to cover these cases.

Reported-by: Jian He <jian.universality@gmail.com>
Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://postgr.es/m/CACJufxHunVg81JMuNo8Yvv_hJD0DicgaVN2Wteu8aJbVJPBjZA@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b5511fed500eb526a547f38597307552fa7acd08

Modified Files
--------------
src/backend/parser/parse_expr.c                  | 23 +++++++++++++++--------
src/test/regress/expected/sqljson_queryfuncs.out |  8 ++++++++
src/test/regress/sql/sqljson_queryfuncs.sql      |  2 ++
3 files changed, 25 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Add parallelism support for TID Range Scans
Next
From: Amit Langote
Date:
Subject: pgsql: Fix error reporting for SQL/JSON path type mismatches