pgsql: Fix WaitLSNWakeup() fast-path check for InvalidXLogRecPtr - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Fix WaitLSNWakeup() fast-path check for InvalidXLogRecPtr
Date
Msg-id E1vKDVj-006iAd-12@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix WaitLSNWakeup() fast-path check for InvalidXLogRecPtr

WaitLSNWakeup() incorrectly returned early when called with
InvalidXLogRecPtr (meaning "wake all waiters"), because the fast-path
check compared minWaitedLSN > 0 without validating currentLSN first.
This caused WAIT FOR LSN commands to wait indefinitely during standby
promotion until random signals woke them.

Add an XLogRecPtrIsValid() check before the comparison so that
InvalidXLogRecPtr bypasses the fast-path and wakes all waiters immediately.

Discussion: https://postgr.es/m/CABPTF7UieOYbOgH3EnQCasaqcT1T4N6V2wammwrWCohQTnD_Lw%40mail.gmail.com
Author: Xuneng Zhou <xunengzhou@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ede6acef49673df0a880edae405ca69393bb48d0

Modified Files
--------------
src/backend/access/transam/xlogwait.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Add test for postgresql.conf.sample line syntax
Next
From: David Rowley
Date:
Subject: pgsql: Doc: include MERGE in variable substitution command list