pgsql: Revert "Drop unnamed portal immediately after execution to compl - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Revert "Drop unnamed portal immediately after execution to compl
Date
Msg-id E1vJmYl-006WOs-2R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Drop unnamed portal immediately after execution to completion"

This reverts commit 1fd981f05369, based on concerns that the logging
improvements do not justify the protocol breakage of dropping an unnamed
portal once its execution has completed.

It seems unlikely that one would try to send an execute or describe
message after the portal has been used, but if they do such
post-completion messages would not be able to process as the previous
versions.  Let's revert this change for now so as we keep compatibility
and consider a different solution.

The tests added by 76bba033128a track the pre-1fd981f05369 behavior, and
are still valid.

Discussion: https://postgr.es/m/CA+TgmoYFJyJNQw3RT7veO3M2BWRE9Aw4hprC5rOcawHZti-f8g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/910690415b661186ae44e3b5e538e23eaa48de1b

Modified Files
--------------
doc/src/sgml/protocol.sgml                         |  4 +--
src/backend/tcop/postgres.c                        | 10 -------
src/test/modules/test_misc/t/009_log_temp_files.pl | 33 +++++++++++-----------
3 files changed, 18 insertions(+), 29 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: adjust "Replication Slot" to mention physical & logical
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Doc: add IDs to copy.sgml's and