pgsql: Fix incorrect assignment of InvalidXLogRecPtr to a non-LSN varia - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Fix incorrect assignment of InvalidXLogRecPtr to a non-LSN varia
Date
Msg-id E1vJKZy-006JTK-0h@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix incorrect assignment of InvalidXLogRecPtr to a non-LSN variable.

pg_logical_slot_get_changes_guts() previously assigned InvalidXLogRecPtr to
the local variable upto_nchanges, which is of type int32, not XLogRecPtr.
While this caused no functional issue since InvalidXLogRecPtr is defined as 0,
it was semantically incorrect.

This commit fixes the issue by updating pg_logical_slot_get_changes_guts()
to set upto_nchanges to 0 instead of InvalidXLogRecPtr.

No backpatch is needed, as the previous behavior was harmless.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Steven Niu <niushiji@gmail.com>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwHKHuR5NGnGxU3+ebz7cbC1ZAR=AgG4Bueq==Lj6iX8Sw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/705601c5aeab56aef62dd69ac2b7acf662f08e9c

Modified Files
--------------
src/backend/replication/logical/logicalfuncs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Remove obsolete autovacuum comment.
Next
From: Michael Paquier
Date:
Subject: pgsql: Replace off_t by pgoff_t in I/O routines