pgsql: Sort guc_parameters.dat alphabetically by name - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Sort guc_parameters.dat alphabetically by name
Date
Msg-id E1vFqob-004oTw-23@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Sort guc_parameters.dat alphabetically by name

The order in this list was previously pretty random and had grown
organically over time.  This made it unnecessarily cumbersome to
maintain these lists, as there was no clear guidelines about where to
put new entries.  Also, after the merger of the type-specific GUC
structs, the list still reflected the previous type-specific
super-order.

By using alphabetical order, the place for new entries becomes clear,
and often related entries will be listed close together.

This patch reorders the existing entries in guc_parameters.dat, and it
also augments the generation script to error if an entry is found at
the wrong place.

Note: The order is actually checked after lower-casing, to handle the
likes of "DateStyle".

Reviewed-by: John Naylor <johncnaylorls@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/8fdfb91e-60fb-44fa-8df6-f5dea47353c9@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fce7c73fba4e5e3014c27b8980aa07511d6e0f85

Modified Files
--------------
src/backend/utils/misc/gen_guc_tables.pl  |   10 +
src/backend/utils/misc/guc_parameters.dat | 4918 ++++++++++++++---------------
2 files changed, 2469 insertions(+), 2459 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve planner's estimates of tuple hash table sizes.
Next
From: Michael Paquier
Date:
Subject: pgsql: Add wal_fpi_bytes to VACUUM and ANALYZE logs