pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c.
Date
Msg-id E1vBcna-002yvx-1B@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix memory leaks in pg_combinebackup/reconstruct.c.

One code path forgot to free the separately-malloc'd filename
part of a struct rfile.  Another place freed the filename but
forgot the struct rfile itself.  These seem worth fixing because
with a large backup we could be dealing with many files.

Coverity found the bug in make_rfile().  I found the other one
by manual inspection.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9224c3025243a3daeb49fa58b948c6e1fdf99501

Modified Files
--------------
src/bin/pg_combinebackup/reconstruct.c | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Remove make_temptable_name_n().
Next
From: Tom Lane
Date:
Subject: pgsql: Fix memory leaks in scripts/vacuuming.c.