pgsql: Fix reset of incorrect hash iterator in GROUPING SETS queries - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Fix reset of incorrect hash iterator in GROUPING SETS queries
Date
Msg-id E1v9xI5-002Ehy-2K@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix reset of incorrect hash iterator in GROUPING SETS queries

This fixes an unlikely issue when fetching GROUPING SET results from
their internally stored hash tables.  It was possible in rare cases that
the hash iterator would be set up incorrectly which could result in a
crash.

This was introduced in 4d143509c, so backpatch to v18.

Many thanks to Yuri Zamyatin for reporting and helping to debug this
issue.

Bug: #19078
Reported-by: Yuri Zamyatin <yuri@yrz.am>
Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Jeff Davis <pgsql@j-davis.com>
Discussion: https://postgr.es/m/19078-dfd62f840a2c0766@postgresql.org
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5c0a20003b4396930a354105ccf47402ca5047d2

Modified Files
--------------
src/backend/executor/nodeAgg.c | 2 +-
src/include/lib/simplehash.h   | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Englishify comment wording
Next
From: David Rowley
Date:
Subject: pgsql: Fix reset of incorrect hash iterator in GROUPING SETS queries