pgsql: pg_createsubscriber: Use new routine to retrieve data of PG_VERS - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: pg_createsubscriber: Use new routine to retrieve data of PG_VERS
Date
Msg-id E1v8r1G-001kHF-1D@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_createsubscriber: Use new routine to retrieve data of PG_VERSION

pg_createsubscriber is documented as requiring the same major version as
the target clusters.  Attempting to use this tool on a cluster where the
control file version read does not match with the version compiled with
would lead to the following error message:
pg_createsubscriber: error: control file appears to be corrupt

This is confusing as the control file is correct: only the version
expected does not match.  This commit integrates pg_createsubscriber
with the facility added by cd0be131ba6f, where the contents of
PG_VERSION are read and compared with the value of PG_MAJORVERSION_NUM
expected by the tool.  This puts pg_createsubscriber in line with the
documentation, with a better error message when the version does not
match.

Author: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/aONDWig0bIGilixs@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fa55be2a506a77772cab1d62430cc2217413f9ec

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: pg_resetwal: Use new routine to retrieve data of PG_VERSION
Next
From: Amit Kapila
Date:
Subject: pgsql: Standardize use of REFRESH PUBLICATION in code and messages.