pgsql: Remove overzealous _bt_killitems assertion. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Remove overzealous _bt_killitems assertion.
Date
Msg-id E1v7IEI-0012v0-0a@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove overzealous _bt_killitems assertion.

An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/314004021e549770d3d57fd0cf286050b948472d

Modified Files
--------------
src/backend/access/nbtree/nbtutils.c | 1 -
1 file changed, 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix two typos in xlogstats.h and xlogstats.c
Next
From: Álvaro Herrera
Date:
Subject: pgsql: dbase_redo: Fix Valgrind-reported memory leak