pgsql: Allow negative aggtransspace to indicate unbounded state size - Mailing list pgsql-committers

From Richard Guo
Subject pgsql: Allow negative aggtransspace to indicate unbounded state size
Date
Msg-id E1v6PBW-000dzm-2S@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow negative aggtransspace to indicate unbounded state size

This patch reuses the existing aggtransspace in pg_aggregate to
signal that an aggregate's transition state can grow unboundedly.  If
aggtransspace is set to a negative value, it now indicates that the
transition state may consume unpredictable or large amounts of memory,
such as in aggregates like array_agg or string_agg that accumulate
input rows.

This information can be used by the planner to avoid applying
memory-sensitive optimizations (e.g., eager aggregation) when there is
a risk of excessive memory usage during partial aggregation.

Bump catalog version.

Per idea from Robert Haas, though applied differently than originally
suggested.

Discussion: https://postgr.es/m/CA+TgmoYbkvYwLa+1vOP7RDY7kO2=A7rppoPusoRXe44VDOGBPg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/185e304263347d0979832f7a08a812872d136b18

Modified Files
--------------
doc/src/sgml/catalogs.sgml               |  5 ++++-
doc/src/sgml/ref/create_aggregate.sgml   | 11 ++++++++---
src/include/catalog/catversion.h         |  2 +-
src/include/catalog/pg_aggregate.dat     | 10 ++++++----
src/test/regress/expected/opr_sanity.out |  2 +-
src/test/regress/sql/opr_sanity.sql      |  2 +-
6 files changed, 21 insertions(+), 11 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Improve description of some WAL records for GIN
Next
From: Robert Haas
Date:
Subject: pgsql: Add ExplainState argument to pg_plan_query() and planner().