pgsql: Don't include access/htup_details.h in executor/tuptable.h - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Don't include access/htup_details.h in executor/tuptable.h
Date
Msg-id E1v5RnH-000CjN-2d@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't include access/htup_details.h in executor/tuptable.h

This is not at all needed; I suspect it was a simple mistake in commit
5408e233f066.  It causes htup_details.h to bleed into a huge number of
places via execnodes.h.  Remove it and fix fallout.

Discussion: https://postgr.es/m/202510021240.ptc2zl5cvwen@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a8b5b11e48a8fb086228542d1d4b379f23bdc1e

Modified Files
--------------
contrib/pageinspect/btreefuncs.c                          | 1 +
contrib/pageinspect/gistfuncs.c                           | 1 +
contrib/pg_stat_statements/pg_stat_statements.c           | 1 +
contrib/pg_walinspect/pg_walinspect.c                     | 1 +
contrib/postgres_fdw/connection.c                         | 1 +
contrib/xml2/xslt_proc.c                                  | 1 +
src/backend/access/common/printsimple.c                   | 1 +
src/backend/access/common/printtup.c                      | 1 +
src/backend/access/common/tupconvert.c                    | 1 +
src/backend/backup/walsummaryfuncs.c                      | 1 +
src/backend/catalog/pg_attrdef.c                          | 1 +
src/backend/catalog/pg_largeobject.c                      | 1 +
src/backend/catalog/pg_parameter_acl.c                    | 1 +
src/backend/commands/explain_dr.c                         | 1 +
src/backend/commands/proclang.c                           | 1 +
src/backend/commands/statscmds.c                          | 1 +
src/backend/executor/nodeGatherMerge.c                    | 1 +
src/backend/executor/nodeMemoize.c                        | 1 +
src/backend/executor/tstoreReceiver.c                     | 1 +
src/backend/optimizer/path/indxpath.c                     | 1 +
src/backend/optimizer/util/pathnode.c                     | 1 +
src/backend/parser/parse_coerce.c                         | 1 +
src/backend/parser/parse_expr.c                           | 1 +
src/backend/utils/adt/arrayfuncs.c                        | 1 +
src/backend/utils/adt/hbafuncs.c                          | 1 +
src/backend/utils/adt/json.c                              | 1 +
src/backend/utils/adt/misc.c                              | 1 +
src/backend/utils/adt/rangetypes.c                        | 1 +
src/backend/utils/adt/xid8funcs.c                         | 1 +
src/backend/utils/fmgr/fmgr.c                             | 1 +
src/backend/utils/misc/guc.c                              | 1 +
src/include/executor/tuptable.h                           | 1 -
src/test/modules/injection_points/injection_stats_fixed.c | 1 +
33 files changed, 32 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Don't include execnodes.h in brin.h or gin.h
Next
From: Tom Lane
Date:
Subject: pgsql: Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c.