pgsql: Fix StatisticsObjIsVisibleExt() for pg_temp. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Fix StatisticsObjIsVisibleExt() for pg_temp.
Date
Msg-id E1v3IQV-000eyF-0Y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix StatisticsObjIsVisibleExt() for pg_temp.

Neighbor get_statistics_object_oid() ignores objects in pg_temp, as has
been the standard for non-relation, non-type namespace searches since
CVE-2007-2138.  Hence, most operations that name a statistics object
correctly decline to map an unqualified name to a statistics object in
pg_temp.  StatisticsObjIsVisibleExt() did not.  Consequently,
pg_statistics_obj_is_visible() wrongly returned true for such objects,
psql \dX wrongly listed them, and getObjectDescription()-based ereport()
and pg_describe_object() wrongly omitted namespace qualification.  Any
malfunction beyond that would depend on how a human or application acts
on those wrong indications.  Commit
d99d58cdc8c0b5b50ee92995e8575c100b1a458a introduced this.  Back-patch to
v13 (all supported versions).

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/20250920162116.2e.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6778fbca63c9efffefee8086914cef8428c4ccad

Modified Files
--------------
src/backend/catalog/namespace.c         |  3 +++
src/test/regress/expected/stats_ext.out | 14 ++++++++++++++
src/test/regress/sql/stats_ext.sql      |  8 ++++++++
3 files changed, 25 insertions(+)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: test_bitmapset: Expand more the test coverage
Next
From: David Rowley
Date:
Subject: pgsql: Remove unused parameter from find_window_run_conditions()