pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes.
Date
Msg-id E1uxBYB-000PXc-1t@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix oversights in pg_event_trigger_dropped_objects() fixes.

Commit a0b99fc12 caused pg_event_trigger_dropped_objects()
to not fill the object_name field for schemas, which it
should have; and caused it to fill the object_name field
for default values, which it should not have.

In addition, triggers and RLS policies really should behave
the same way as we're making column defaults do; that is,
they should have is_temporary = true if they belong to a
temporary table.

Fix those things, and upgrade event_trigger.sql's woefully
inadequate test coverage of these secondary output columns.

As before, back-patch only to v15.

Reported-by: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/bd7b4651-1c26-4d30-832b-f942fabcb145@postgrespro.ru
Backpatch-through: 15

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f6c8e7824c5d3872556d1f717f5a5328e5f3e594

Modified Files
--------------
src/backend/commands/event_trigger.c        |  88 ++++++++++++-
src/test/regress/expected/event_trigger.out | 184 +++++++++++++++++-----------
src/test/regress/sql/event_trigger.sql      |  55 +++++++--
3 files changed, 243 insertions(+), 84 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Replace tests of ALTER DATABASE RESET TABLESPACE.
Next
From: Tom Lane
Date:
Subject: pgsql: Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name