pgsql: Add test to prevent premature removal of conflict-relevant data. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Add test to prevent premature removal of conflict-relevant data.
Date
Msg-id E1uvae1-0016or-2v@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add test to prevent premature removal of conflict-relevant data.

A test has been added to ensure that conflict-relevant data is not
prematurely removed when a concurrent prepared transaction is being
committed on the publisher.

This test introduces an injection point that simulates the presence of a
prepared transaction in the commit phase, validating that the system
correctly delays conflict slot advancement until the transaction is fully
committed.

Additionally, the test serves as a safeguard for developers, ensuring that
the acquisition of the commit timestamp does not occur before marking
DELAY_CHKPT_IN_COMMIT in RecordTransactionCommitPrepared.

Reported-by: Robert Haas <robertmhaas@gmail.com>
Author: Zhijie Hou <houzj.fnst@fujitsu.com>
Reviewed-by: shveta malik <shveta.malik@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/OS9PR01MB16913F67856B0DA2A909788129400A@OS9PR01MB16913.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6456c6e2c4ad1cf9752e09cce37bfcfe2190c5e0

Modified Files
--------------
src/backend/access/transam/twophase.c    |   6 ++
src/test/subscription/Makefile           |   4 +-
src/test/subscription/meson.build        |   5 +-
src/test/subscription/t/035_conflicts.pl | 160 +++++++++++++++++++++++++++++++
4 files changed, 173 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix corruption of pgstats shared hashtable due to OOM failures
Next
From: Melanie Plageman
Date:
Subject: pgsql: Remove unneeded VM pin from VM replay