pgsql: Fix replica identity check for MERGE. - Mailing list pgsql-committers

From Dean Rasheed
Subject pgsql: Fix replica identity check for MERGE.
Date
Msg-id E1uu7bC-000S0J-2M@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix replica identity check for MERGE.

When executing a MERGE, check that the target relation supports all
actions mentioned in the MERGE command. Specifically, check that it
has a REPLICA IDENTITY if it publishes updates or deletes and the
MERGE command contains update or delete actions. Failing to do this
can silently break replication.

Author: Zhijie Hou <houzj.fnst@fujitsu.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Tested-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/OS3PR01MB57180C87E43A679A730482DF94B62@OS3PR01MB5718.jpnprd01.prod.outlook.com
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5481cc332b0fc8ca242966813a6675a514c6917b

Modified Files
--------------
src/backend/executor/execMain.c           | 27 ++++++++++++++++++++++++---
src/backend/executor/execPartition.c      |  6 ++++--
src/backend/executor/nodeModifyTable.c    |  6 +++++-
src/include/executor/executor.h           |  3 ++-
src/test/regress/expected/publication.out | 28 ++++++++++++++++++++++++++++
src/test/regress/sql/publication.sql      | 31 +++++++++++++++++++++++++++++++
6 files changed, 94 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Dean Rasheed
Date:
Subject: pgsql: Fix replica identity check for INSERT ON CONFLICT DO UPDATE.
Next
From: Dean Rasheed
Date:
Subject: pgsql: Fix compiler error introduced by 5386bfb9c1f.