pgsql: vacuumdb: Make vacuumdb --analyze-only process partitioned table - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: vacuumdb: Make vacuumdb --analyze-only process partitioned table
Date
Msg-id E1uoaGL-000kp5-13@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
vacuumdb: Make vacuumdb --analyze-only process partitioned tables.

vacuumdb should follow the behavior of the underlying VACUUM and ANALYZE
commands. When --analyze-only is used, it ought to analyze regular tables,
materialized views, and partitioned tables, just as ANALYZE (with no explicit
target tables) does. Otherwise, it should only process regular tables and
materialized views, since VACUUM skips partitioned tables when no targets
are given.

Previously, vacuumdb --analyze-only skipped partitioned tables. This was
inconsistent, and also inconvenient after pg_upgrade, where --analyze-only
is typically used to gather missing statistics.

This commit fixes the behavior so that vacuumdb --analyze-only also processes
partitioned tables. As a result, both vacuumdb --analyze-only and
ANALYZE (with no explicit targets) now analyze regular tables,
partitioned tables, and materialized views, but not foreign tables.

Because this is a nontrivial behavior change, it is applied only to master.

Reported-by: Zechman, Derek S <Derek.S.Zechman@snapon.com>
Author: Laurenz Albe <laurenz.albe@cybertec.at>
Co-authored-by: Mircea Cadariu <cadariu.mircea@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CO1PR04MB8281387B9AD9DE30976966BBC045A%40CO1PR04MB8281.namprd04.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6429e5b771dbb98aa56441677b79cdb58f6e1675

Modified Files
--------------
doc/src/sgml/ref/vacuumdb.sgml    |  9 +++++++++
src/bin/scripts/t/100_vacuumdb.pl | 11 +++++++++++
src/bin/scripts/vacuumdb.c        | 24 ++++++++++++++++++++----
3 files changed, 40 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Fix comment for MAX_SIMUL_LWLOCKS.
Next
From: Bertrand Drouvot
Date:
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file